Merged
Conversation
Replaced the synchronous worker thread with an asynchronous method in MqttValuePublisher to enhance error handling and logging. Simplified the Ensure.NotNull calls and adjusted logging statements for better readability. Added minor formatting changes to improve code consistency.
Introduced new unit tests for DataProcessing to validate SmlValueProcessor behavior. Updated SmlValueProcessor to track GridPowerBalance and use a customizable TimeProvider. Made minor refactors and included new test project setup in the solution file.
Previously, the script deleted the contents of the installation directory directly. Now, it renames the existing installation directory to a backup location before proceeding, ensuring no files are lost until the new installation is confirmed successful.
Removed the redundant ContentType setting when publishing MQTT messages for cleaner code. Updated SmlValueProcessor to ignore zero values and removed unnecessary complete action in the subscription. Adjusted package versions in the project file to match the correct dependencies.
Added a new async method to handle MQTT client reconnection on disconnection. Modified message publishing to support both JSON and string payloads with a new `WriteAsJson` flag in `SmartMeterValue`. Updated MQTTnet package version and refactored server stop procedures for better code organization.
Corrected the sign inversion logic for grid power balance calculation in SmlValueProcessor. The update ensures that current purchasing power and current selling power values are processed with the correct sign. This resolves issues with interpreting power flow direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.