Fabric version is incompatible with Kilt

[BluSpring]

Hi, I am the developer of Kilt, a mod designed to load Forge mods in Fabric. Essentially, think of the Connector mod but for Fabric -> Forge.

Unfortunately, CreativeCore's Fabric build is entirely incompatible with Kilt due to incredibly simplified versions of Forge's classes being included in CreativeCore, and in most cases, CreativeCore's Forge classes will end up loading first before Kilt's even has a chance, thus causing a crash on any Forge mods that try to access any Forge methods that aren't implemented in CreativeCore.

I wanted to know and work with you on what could be done in order to bypass this issue. A few ideas I have for what Kilt could do:

• Try to figure out how to load Kilt's Forge classes before CreativeCore does
• Overwrite CreativeCore's Forge classes with Kilt's via Fabric-ASM (really don't want to do this, but it's something I can do)
• Separate classloader system for Forge mods specifically (not something I want to do, I feel like this could ultimately have its own issues)

[SrRapero720]

This same issue was solved for Connector. And that was possible because fabric annotations are only visible in compilation time (not in runtime), making easy just implement fabric loader as a compile only dependency in Neo/Forge

Neo/Forge annotations are visible in runtime, applying the same "patch" in fabric compiling will cause a crash by a no exiting runtime annotation.

So it's not simple as the fabric fix

[BluSpring]

That's what I figured, but the annotations aren't the problem here for me, it's specifically the stubs (PlayStreamingSourceEvent, IForgeLevel, LazyOptional, IItemHandler)

[BluSpring]

What I could have Kilt do is go through all loaded Fabric mods and use Fabric-ASM to directly replace the classes with the Forge equivalents, but in doing so I'd also have to figure out how to merge the two correctly, which would be painful but might be needed.

[CreativeMD]

Are we talking about 1.20 or 1.21.

For 1.21 I went through the files. There is no LazyOptional in that version. There is ILevelExtension which is unecessary and can be easily removed. The IItemHandler I guess can also be worked around with.

The PlayStreamingSourceEvent is for AmbientSound and is a way to get around neoforge depending code. I guess I can also figure out a solution for this, but it will be messy.

For me the question is about what minecraft version are we talking about?

[BluSpring]

Kilt is on 1.20.1 currently, but will also be on 1.21+ later

[BluSpring]

Additionally, I believe one of the crashes in Kilt is actually due to the @Mod annotation? This one's the most difficult to work around on Kilt's end, but fortunately the fix for that is very easy on CreativeCore's side - it's just to add the optional "dist" argument to the annotation I believe.

If there's anything that you don't want to work around yourself, I can try to do so manually on Kilt's end by attempting to force-load the Forge classes within Kilt instead.

[CreativeMD]

Alright. Released a new version for 1.20.1, which gets rid of all the classes. Can you test and see if it works? If it does I will port these changes to 1.21 as well. Actually most of the classes where already out of use.

[BluSpring]

Seems to work perfectly now, thank you very much :D

[CreativeMD]

Very cool. I ported the changes to 1.21 as well. They will be part of the next release.