Reset TPM on boot #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Pozella <Ian.Pozella@imgtec.com>
Signed-off-by: Ian Pozella <Ian.Pozella@imgtec.com>
We define some empty implementations of the board_*_init functions but don't actually have them enabled. This is confusing as if used they won't actually do anything. Therefore have enabled any that we actually use and removed empty definitions of disabled ones. Signed-off-by: Ian Pozella <Ian.Pozella@imgtec.com>
abhijit-mahajani-imgtec
suggested changes
Dec 9, 2016
board/imgtec/pistachio_bub/mfio.h
Outdated
| void mfio_setup_led(void); | ||
| #endif | ||
|
|
||
| #if defined(CONFIG_TPM) |
Contributor
There was a problem hiding this comment.
why not CONFIG_TARGET_PISTACHIO_MARDUK?
The current version of the board has the tpm reset line connected to a gpio. This causes security issues meaning we need a new HW spin but to make do with what we have at least reset the tpm on boot. Therfore have added mfio_setup_tpm function and call it as part of tpm initialisation. This is certainly not the best place to put this but considering the current arch of 'pistachio_bub is king' there isn't much else we can do without refactoring everything. Signed-off-by: Ian Pozella <Ian.Pozella@imgtec.com>
abhijit-mahajani-imgtec
approved these changes
Dec 9, 2016
Contributor
abhijit-mahajani-imgtec
left a comment
abhijit-mahajani-imgtec
left a comment
There was a problem hiding this comment.
Verified with old bootloader not giving error on powered up
tpm init && tpm startup TPM_ST_CLEAR
but now its giving error since already initialized.
pistachio # tpm init && tpm startup TPM_ST_CLEAR
Error: -16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added mfio support to be able to reset the TPM via gpio. Additionally found that board_late_init wasn't being called so enabled it and moved watchdog support out into it's standard location.
Tested by making sure that both a modified tpm reset board and a current version board are able to boot with a working tpm and still work after being reset (using reset button, using software command and cycling power).
This connects CreatorDev/openwrt#32