use String::Builder for building query strings instead of Array.join#186
Merged
Conversation
435ad7d to
3e439c6
Compare
Merged
Author
|
i'd be interested in a benchmark as well :) |
3aeb206 to
23441d6
Compare
23441d6 to
d190349
Compare
Member
|
Here are the benchmark results I get on this branch: Compared to: https://github.com/Crecto/crecto/wiki/Benchmarks So looks like a bit a performance increase. |
Member
|
FYI i'm just compiling this file with |
fridgerator
approved these changes
Aug 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #181