Skip to content

Conversation

@coffeejunk
Copy link
Contributor

Allow users to update an existing resource without knowledge of it's envelope_id using a POST request.

Fixes #99

@coffeejunk coffeejunk requested a review from leolara June 26, 2017 11:43
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.593% when pulling c6beee9 on coffeejunk:update_without_id into a215670 on CredentialEngine:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.593% when pulling c6beee9 on coffeejunk:update_without_id into a215670 on CredentialEngine:master.

@leolara
Copy link
Contributor

leolara commented Jun 30, 2017

@coffeejunk

I do not think we should based this specifically on cterms:ctid field and ce_engine community:

  • Not all entities have cterms:ctid in the ce_engine community
  • All entities in all communities should have @id field

Hence, I think it should be based on the @id field. Also, we should consider the community prefix for @id

@leolara
Copy link
Contributor

leolara commented Jul 20, 2017

@coffeejunk what about my comments?

@coffeejunk
Copy link
Contributor Author

@leolara I've changed the retrieval to use the @id instead and check if a prefix is used.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.593% when pulling fd0e0a9 on coffeejunk:update_without_id into 2e58617 on CredentialEngine:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.593% when pulling fd0e0a9 on coffeejunk:update_without_id into 2e58617 on CredentialEngine:master.

@coffeejunk coffeejunk merged commit dd90acb into CredentialEngine:master Aug 1, 2017
@coffeejunk coffeejunk deleted the update_without_id branch August 1, 2017 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants