Skip to content

Retrieve resources with case-insensitive ID #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coffeejunk merged 1 commit into from
Jul 12, 2017
Merged

Retrieve resources with case-insensitive ID #119

coffeejunk merged 1 commit into from
Jul 12, 2017

Conversation

@coffeejunk
Copy link
Contributor

@coffeejunk coffeejunk commented Jul 10, 2017

Make retrieval of resources by ID case-insensitive.

While UUIDs should be in lower case in general, a human might try to retrieve a resource with upper case IDs.

Related to #118

@coffeejunk coffeejunk requested a review from leolara July 10, 2017 16:10
@coveralls
Copy link

coveralls commented Jul 10, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.0004%) to 99.591% when pulling cda1678 on coffeejunk:resource-retrieval into 1f9a664 on CredentialEngine:master.

@leolara
Copy link
Contributor

leolara commented Jul 12, 2017

@coffeejunk approved

@coffeejunk coffeejunk merged commit 300779c into CredentialEngine:master Jul 12, 2017
@coffeejunk coffeejunk deleted the resource-retrieval branch July 12, 2017 10:02
@coffeejunk coffeejunk mentioned this pull request Jul 13, 2017
Merged
@coffeejunk coffeejunk mentioned this pull request Aug 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@leolara leolara leolara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coffeejunk @coveralls @leolara