more focus on readability / typos / grammar etc #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er already exists
Updated the parameter name
Member
|
Please make sure your doing the update on the v2.3 branch instead of the master since lots of code have changed. |
Contributor
Author
|
oh - sorry about that. Will do so in the future.
I was just correcting typos mostly - but I'll make sure that I work on the 2.3 branch from now on. :)
…-Logan Gray
( [ callto:404%29%20376-3814 | 404) 376-3814 ]
From: "CrestApps" <notifications@github.com>
To: "CrestApps/laravel-code-generator" <laravel-code-generator@noreply.github.com>
Cc: "Logan Gray" <logan@intensetech.com>, "Author" <author@noreply.github.com>
Sent: Tuesday, March 6, 2018 8:46:02 PM
Subject: Re: [CrestApps/laravel-code-generator] more focus on readability / typos / grammar etc (#48)
Please make sure your doing the update on the v2.3 branch instead of the master since lots of code have changed.
—
You are receiving this because you authored the thread.
Reply to this email directly, [ #48 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AALs3r7fllZBERT-L-H7zoYKh4scPicjks5tbzvagaJpZM4SfsbL | mute the thread ] .
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and hopefully a little friendlier too!