fix: Fix Pipes API destination auth by matching secret key format#6
Merged
kristopherchun merged 1 commit intomainfrom Feb 20, 2026
Merged
fix: Fix Pipes API destination auth by matching secret key format#6kristopherchun merged 1 commit intomainfrom
kristopherchun merged 1 commit intomainfrom
Conversation
The _apply_connection_auth method expected PascalCase keys
(e.g. BasicAuthParameters.Username) when reading from SecretsManager,
but ConnectionService stores secrets using lowercase flat keys
(e.g. {"username": ..., "password": ...}). This caused BASIC and
API_KEY auth to silently fail with empty credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_apply_connection_authin the Pipes API destination target expected PascalCase nested keys (e.g.BasicAuthParameters.Username,ApiKeyAuthParameters.ApiKeyName) when reading connection secrets from SecretsManagerConnectionService._get_secret_value()stores secrets using lowercase flat keys (e.g.{"username": ..., "password": ...}and{"api_key_name": ..., "api_key_value": ...})Authorizationheaders on outbound requestsTest plan