Skip to content
This repository was archived by the owner on Aug 9, 2018. It is now read-only.

Add regression test for Placeholder fallbacks with lifecycle methods …#1

Merged
Cristie merged 1 commit intoCristie:masterfrom
facebook:master
Jul 24, 2018
Merged

Add regression test for Placeholder fallbacks with lifecycle methods …#1
Cristie merged 1 commit intoCristie:masterfrom
facebook:master

Conversation

@Cristie
Copy link
Owner

@Cristie Cristie commented Jul 24, 2018

…(facebook#13254)

Found by @rhagigi

Co-authored-by: Royi Hagigi rhagigi@gmail.com
Co-authored-by: Andrew Clark acdlite@me.com

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (yarn test). Tip: yarn test --watch TestName is helpful in development.
  5. Run yarn test-prod to test in the production environment. It supports the same options as yarn test.
  6. If you need a debugger, run yarn debug-test --watch TestName, open chrome://inspect, and press "Inspect".
  7. Format your code with prettier (yarn prettier).
  8. Make sure your code lints (yarn lint). Tip: yarn linc to only check changed files.
  9. Run the Flow typechecks (yarn flow).
  10. If you haven't already, complete the CLA.

Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html

…13254)

Found by @rhagigi

Co-authored-by: Royi Hagigi <rhagigi@gmail.com>
Co-authored-by: Andrew Clark <acdlite@me.com>
@Cristie Cristie merged commit af07153 into Cristie:master Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants