iOS. There is a crash when a device is registered in FCM.#332
Merged
rdelrosario merged 1 commit intoCrossGeeks:masterfrom Jun 23, 2020
Merged
Conversation
1. The user setup to receive push notifications. 2. The user doesn't want to receive push notifications (unregister him device from FCM) 3. And then the user tries to register again him device in FCM the pendingTopics stack has some values in null.
rdelrosario
approved these changes
Jun 23, 2020
Member
rdelrosario
left a comment
rdelrosario
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce?
bugfix
There is a crash when a device is registered in FCM
🆕 What is the new behavior (if this is a feature change)?
Avoid the crash by adding a validation
🐛 Recommendations for testing
The pendingTopics stack has some values in null.
🤔 Checklist before submitting