device-signer: added support for device signer

[guilleasz-crossmint]

Description

Added support for device signer in wallets-v1.
User can select device signer as signer and sign transactions with it.
It requires a DeviceSignerKeyStorage that is sent through options

Test plan

• Manually tested creating a DeviceSignerKeyStorage for quickstart-devkit and being able to create device signers and sign transactions with it

Package updates

wallets-sdk: minor
react-base: minor

---

[changeset-bot]

🦋 Changeset detected

Latest commit: 60cd5d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@crossmint/client-sdk-react-base	Minor
@crossmint/wallets-sdk	Minor
@crossmint/client-sdk-react-native-ui	Patch
@crossmint/client-sdk-react-ui	Patch
expo-demo	Patch
@crossmint/auth-ssr-nextjs-demo	Patch
@crossmint/client-sdk-nextjs-starter	Patch
@crossmint/wallets-quickstart-devkit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

🔥 Smoke Test Results

⚠️ Test results file not found.

[greptile-apps]

Additional Comments (1)

packages/client/react-base/src/providers/CrossmintWalletBaseProvider.tsx
getWallet missing deviceSignerKeyStorage in options

The getWallet callback does not pass deviceSignerKeyStorage through options, unlike getOrCreateWallet (line 260). When a user calls getWallet with a device signer, the toInternalSignerConfig method in wallet-factory.ts will call options?.deviceSignerKeyStorage?.getKey(...) which will evaluate to undefined, causing it to throw "Device signer not found".

The function signature also only accepts Pick<WalletArgsFor<C>, "chain" | "signer">, which excludes options entirely. To support device signers via getWallet, you would need to either expand the accepted props to include options or find another way to thread deviceSignerKeyStorage through.

Prompt To Fix With AI

This is a comment left during a code review.
Path: packages/client/react-base/src/providers/CrossmintWalletBaseProvider.tsx
Line: 300-307

Comment:
**`getWallet` missing `deviceSignerKeyStorage` in options**

The `getWallet` callback does not pass `deviceSignerKeyStorage` through `options`, unlike `getOrCreateWallet` (line 260). When a user calls `getWallet` with a device signer, the `toInternalSignerConfig` method in `wallet-factory.ts` will call `options?.deviceSignerKeyStorage?.getKey(...)` which will evaluate to `undefined`, causing it to throw `"Device signer not found"`.

The function signature also only accepts `Pick<WalletArgsFor<C>, "chain" | "signer">`, which excludes `options` entirely. To support device signers via `getWallet`, you would need to either expand the accepted props to include `options` or find another way to thread `deviceSignerKeyStorage` through.

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

_{11 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Additional Comments (2)

packages/client/react-base/src/providers/CrossmintWalletBaseProvider.tsx
Missing deviceSignerKeyStorage in dependency arrays

deviceSignerKeyStorage is captured inside both the getOrCreateWallet callback (line 263) and the getWallet callback (line 309), but it is not listed in either dependency array. If the prop changes, these callbacks will continue using the stale reference from the previous render.

This applies to both getOrCreateWallet (here) and getWallet (line 318-325).

        [
            crossmint,
            experimental_customAuth,
            walletStatus,
            wallet,
            resolveSignerConfig,
            initializeWebViewIfNeeded,
            updateCallbacks?.onWalletCreationStart,
            updateCallbacks?.onTransactionStart,
            clientTEEConnection,
            callbacks,
            deviceSignerKeyStorage,
        ]

Prompt To Fix With AI

This is a comment left during a code review.
Path: packages/client/react-base/src/providers/CrossmintWalletBaseProvider.tsx
Line: 276-287

Comment:
**Missing `deviceSignerKeyStorage` in dependency arrays**

`deviceSignerKeyStorage` is captured inside both the `getOrCreateWallet` callback (line 263) and the `getWallet` callback (line 309), but it is not listed in either dependency array. If the prop changes, these callbacks will continue using the stale reference from the previous render.

This applies to both `getOrCreateWallet` (here) and `getWallet` (line 318-325).

```suggestion
        [
            crossmint,
            experimental_customAuth,
            walletStatus,
            wallet,
            resolveSignerConfig,
            initializeWebViewIfNeeded,
            updateCallbacks?.onWalletCreationStart,
            updateCallbacks?.onTransactionStart,
            clientTEEConnection,
            callbacks,
            deviceSignerKeyStorage,
        ]
```

How can I resolve this? If you propose a fix, please make it concise.

---

packages/client/react-base/src/providers/CrossmintWalletBaseProvider.tsx
Missing deviceSignerKeyStorage in getWallet deps

Same issue as getOrCreateWallet — deviceSignerKeyStorage is used on line 309 but not in this dependency array.

        [
            crossmint,
            experimental_customAuth,
            resolveSignerConfig,
            initializeWebViewIfNeeded,
            clientTEEConnection,
            callbacks,
            deviceSignerKeyStorage,
        ]

Prompt To Fix With AI

This is a comment left during a code review.
Path: packages/client/react-base/src/providers/CrossmintWalletBaseProvider.tsx
Line: 318-326

Comment:
**Missing `deviceSignerKeyStorage` in `getWallet` deps**

Same issue as `getOrCreateWallet` — `deviceSignerKeyStorage` is used on line 309 but not in this dependency array.

```suggestion
        [
            crossmint,
            experimental_customAuth,
            resolveSignerConfig,
            initializeWebViewIfNeeded,
            clientTEEConnection,
            callbacks,
            deviceSignerKeyStorage,
        ]
```

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

_{11 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

_{12 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

_{12 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Missing unit tests for device signer validation logic

This PR adds substantial new validation and error handling logic across wallet-factory.ts, signers/index.ts, and device.ts — including checks for missing deviceSignerKeyStorage, admin signer restrictions, and key mapping — but no corresponding unit tests were added. The existing wallet-factory.test.ts has no coverage of device signer scenarios.

At minimum, tests should cover:

• Device signer as admin signer is rejected (line 172)
• Missing deviceSignerKeyStorage throws in toInternalSignerConfig (line 317)
• saveDeviceSignerKeyIfNeeded correctly maps keys and throws when storage is missing
• assembleSigner throws when deviceSignerKeyStorage is null for device config

Context Used: Rule from dashboard - Add unit tests when implementing new validation logic or error handling features. (source)

Prompt To Fix With AI

This is a comment left during a code review.
Path: packages/wallets/src/wallets/wallet-factory.ts
Line: 216-231

Comment:
**Missing unit tests for device signer validation logic**

This PR adds substantial new validation and error handling logic across `wallet-factory.ts`, `signers/index.ts`, and `device.ts` — including checks for missing `deviceSignerKeyStorage`, admin signer restrictions, and key mapping — but no corresponding unit tests were added. The existing `wallet-factory.test.ts` has no coverage of device signer scenarios.

At minimum, tests should cover:
- Device signer as admin signer is rejected (line 172)
- Missing `deviceSignerKeyStorage` throws in `toInternalSignerConfig` (line 317)
- `saveDeviceSignerKeyIfNeeded` correctly maps keys and throws when storage is missing
- `assembleSigner` throws when `deviceSignerKeyStorage` is null for device config

**Context Used:** Rule from `dashboard` - Add unit tests when implementing new validation logic or error handling features. ([source](https://app.greptile.com/review/custom-context?memory=9dc35ad5-5868-49a3-bbcb-a42edc5ee697))

How can I resolve this? If you propose a fix, please make it concise.