Skip to content

Fix element.query_selector#43

Merged
CrowdHailer merged 1 commit into
CrowdHailer:masterfrom
agj:fix-query-selector
Apr 22, 2026
Merged

Fix element.query_selector#43
CrowdHailer merged 1 commit into
CrowdHailer:masterfrom
agj:fix-query-selector

Conversation

@agj
Copy link
Copy Markdown

@agj agj commented Apr 22, 2026

Hi! plinth/browser/element's query_selector wasn't working for me, and I realized that the code was still using the outdated JavaScript API.

Here's the error message I got on the browser's console:

Uncaught ReferenceError: Ok is not defined
    querySelector element_ffi.mjs:233
    on_clicked_document app.gleam:1

So I changed new Ok to Result$Ok (like in #37) and now it works for me.

By the way, by grepping I didn't find any other case similar to this.

@CrowdHailer CrowdHailer merged commit 8e66d8a into CrowdHailer:master Apr 22, 2026
@CrowdHailer
Copy link
Copy Markdown
Owner

Thank you. looks good to me. I wonder how this one passed by the previous update

@agj
Copy link
Copy Markdown
Author

agj commented Apr 22, 2026

Maybe improper use of grep? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants