feat(container-pull): add ability to add custom tag when copying to a registry #406
+70
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a registry Fixes CrowdStrike#405 This PR introduces the `--copy-custom-tag` option for the container pull script that now allows a user to use a custom tag when copying an image to registry.
evanstoner
requested changes
Mar 10, 2025
redhatrises
reviewed
Mar 10, 2025
Contributor
redhatrises
left a comment
redhatrises
left a comment
There was a problem hiding this comment.
I think the only thing I would recommend is to come up with a different tag name other than latest.
redhatrises
reviewed
Mar 10, 2025
| # If Skopeo is being used, the platform must be overridden | ||
| if grep -qw "skopeo" "$CONTAINER_TOOL"; then | ||
| "$CONTAINER_TOOL" copy --override-arch "$(platform_override)" "docker://$FULLIMAGEPATH" "docker://$COPYPATH" | ||
| "$CONTAINER_TOOL" copy --override-arch "$(platform_override)" --override-os linux "docker://$FULLIMAGEPATH" "docker://$COPYPATH" |
Contributor
There was a problem hiding this comment.
It's the override-os meant to be configurable?
Contributor
Author
There was a problem hiding this comment.
@redhatrises this is to prevent issues when using skopeo on macOS. W/O this it will think that your <os/platform> is incorrect so this is to ensure we say linux.. This doesn't impact Linux, I tested this and it works the same.
redhatrises
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405
This PR introduces the
--copy-custom-tagoption for the container pull script that now allows a user to use a custom tag when copying an image to registry.