Add E2E tests for extension and workflow execution#67
Merged
Conversation
Implements comprehensive E2E testing covering: - UI extension rendering (hello extension in detection details) - Workflow execution (3 workflows with full execution + parameters) - Workflow rendering (ServiceNow workflow without execution) - App installation with ServiceNow API configuration - App uninstallation with 3-dot menu pattern Framework: - Playwright with Page Object Model - Semantic locators (getByRole > getByText > getByTestId) - Smart waiting and retry strategies - Comprehensive logging and error handling All tests verified working with app both installed and uninstalled beforehand. 8/8 tests passing.
mraible
force-pushed
the
e2e-workflow-execution
branch
from
c20c448 to
4321a48
Compare
- Corrected app name from category-blocking to functions-python - Fixed APP_NAME environment variable - Added Installation section with npm ci command - Enhanced Test Structure section with detailed component descriptions
- Replace direct URL navigation with menu-based navigation for reliability - Menu structure is stable while URLs can change (e.g., /activity/detections → /activity-v2/detections) - Remove sensitive test data from comments
- Add home navigation before opening menu - Use data-test-selector to avoid strict mode violations - Use popout-button selector for Next-Gen SIEM menu item - Use section-link selector for Incidents link - Prevents matching home page cards instead of menu items
- Add Foundry home navigation before opening menu in Endpoint Detections - Increase app uninstall success message timeout from 10s to 30s
mraible
force-pushed
the
e2e-workflow-execution
branch
from
56f4b1a to
4aff7cb
Compare
Addresses PR feedback from Javier to avoid mixing import/require syntax
- Update AppCatalogPage waitForInstallation() to wait for both 'installing' and 'installed' toast messages sequentially - Throw clear error if 'installing' message never appears - Wait up to 60s for final 'installed' or 'error' message - Detect and report installation failures immediately
Removed serial mode configuration to allow tests to run in parallel. Tests now execute concurrently using 4 workers locally (2 in CI), reducing overall execution time while maintaining stability. All 5 tests passed successfully in parallel mode with no race conditions.
mraible
force-pushed
the
e2e-workflow-execution
branch
from
dd96e84 to
42012d9
Compare
prvn
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements comprehensive E2E testing for foundry-sample-functions-python covering:
Test Coverage:
Key Features:
Framework:
All tests verified working with app both installed and uninstalled beforehand.