Skip to content

Improve E2E test reliability with better selectors and error handling #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mraible merged 1 commit into from
Dec 5, 2025
Merged

Improve E2E test reliability with better selectors and error handling #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions e2e/src/pages/AppCatalogPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,11 @@ export class AppCatalogPage extends BasePage {

await this.navigateToPath('/foundry/app-catalog', 'App catalog page');

const searchBox = this.page.getByRole('searchbox', { name: 'Search' });
await searchBox.fill(appName);
await this.page.keyboard.press('Enter');
await this.page.waitForLoadState('networkidle');
const filterBox = this.page.getByPlaceholder('Type to filter');
if (await filterBox.isVisible().catch(() => false)) {
await filterBox.fill(appName);
await this.page.waitForLoadState('networkidle');
}

const appLink = this.page.getByRole('link', { name: appName, exact: true });

Expand Down Expand Up @@ -220,15 +221,18 @@ export class AppCatalogPage extends BasePage {
const errorMessage = this.page.getByText(`Error installing ${appName}`).first();

try {
await Promise.race([
const result = await Promise.race([
installedMessage.waitFor({ state: 'visible', timeout: 60000 }).then(() => 'success'),
errorMessage.waitFor({ state: 'visible', timeout: 60000 }).then(() => 'error')
]).then(result => {
if (result === 'error') {
throw new Error(`Installation failed for app '${appName}' - error message appeared`);
}
this.logger.success('Installation completed successfully - "installed" message appeared');
});
]);

if (result === 'error') {
// Get the actual error message from the toast and clean up formatting
const errorText = await errorMessage.textContent();
const cleanError = errorText?.replace(/\s+/g, ' ').trim() || 'Unknown error';
throw new Error(`Installation failed for app '${appName}': ${cleanError}`);
}
this.logger.success('Installation completed successfully - "installed" message appeared');
} catch (error) {
if (error.message.includes('Installation failed')) {
throw error;
Expand Down
7 changes: 4 additions & 3 deletions e2e/src/pages/SocketNavigationPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,20 +42,21 @@ export class SocketNavigationPage extends BasePage {
await this.page.waitForLoadState('networkidle');

// Click "Endpoint security"
const endpointSecurityButton = this.page.getByRole('button', { name: /Endpoint security/i });
const navigation = this.page.getByRole('navigation');
const endpointSecurityButton = navigation.getByRole('button', { name: /Endpoint security/ });
await endpointSecurityButton.click();
await this.waiter.delay(500);

// Click "Monitor" to expand submenu (if not already expanded)
const monitorButton = this.page.getByRole('button', { name: /^Monitor$/i });
const monitorButton = navigation.getByRole('button', { name: 'Monitor', exact: true });
const isExpanded = await monitorButton.getAttribute('aria-expanded');
if (isExpanded !== 'true') {
await monitorButton.click();
await this.waiter.delay(500);
}

// Click "Endpoint detections" link
const endpointDetectionsLink = this.page.getByRole('link', { name: /Endpoint detections/i });
const endpointDetectionsLink = navigation.getByRole('link', { name: /Endpoint detections/ });
await endpointDetectionsLink.click();

// Wait for page to load
Expand Down
17 changes: 9 additions & 8 deletions e2e/src/pages/WorkflowsPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ export class WorkflowsPage extends BasePage {
await menuButton.click();
await this.page.waitForLoadState('networkidle');

// Click Fusion SOAR in the navigation menu (not the home page cards)
const navigation = this.page.locator('nav, [role="navigation"]');
const fusionSoarButton = navigation.getByRole('button', { name: 'Fusion SOAR' });
// Click Fusion SOAR button in the navigation menu (not the content buttons)
// Look for the navigation and find the exact "Fusion SOAR" button (not content that mentions Fusion SOAR)
const navigation = this.page.getByRole('navigation');
const fusionSoarButton = navigation.getByRole('button', { name: 'Fusion SOAR', exact: true });
await fusionSoarButton.click();
await this.page.waitForTimeout(500);

// Click Workflows link
const workflowsLink = this.page.getByRole('link', { name: 'Workflows' });
Expand Down Expand Up @@ -161,11 +161,12 @@ export class WorkflowsPage extends BasePage {
async () => {
this.logger.info(`Executing workflow: ${workflowName}`);

// Open the workflow
await this.openWorkflow(workflowName);
// Ensure we're on the workflows list page, not an individual workflow page
await this.navigateToWorkflows();

// Click "Open menu" button
const openMenuButton = this.page.getByRole('button', { name: /open menu/i });
// Click "Open menu" button for the specific workflow row
const workflowRow = this.page.getByRole('row', { name: new RegExp(workflowName, 'i') });
const openMenuButton = workflowRow.getByRole('button', { name: /open menu/i });
await openMenuButton.click();

// Click "Execute workflow" option
Expand Down