Add GitHub Actions for e2e tests#7
Conversation
Co-authored-by: Carlos Matos <matosc15@gmail.com>
| - name: Prepare app manifests | ||
| run: | | ||
| # Remove IDs from manifest | ||
| yq -i 'del(.. | select(has("id")).id) | del(.. | select(has("app_id")).app_id)' manifest.yml |
There was a problem hiding this comment.
This just gave me the idea, maybe we can add a test that checks we didn't add ids by mistake to the manifest
There was a problem hiding this comment.
Yes. I feel like we might want to write a tool that checks a Foundry sample app's repo for all the things necessary before it can be made public. However, some apps require IDs in them. For example, the Threat Hunting tutorial requires IDs or there's an import error. CrowdStrike/foundry-tutorial-threat-hunting#1
| yq -i 'del(.. | select(has("id")).id) | del(.. | select(has("app_id")).app_id)' manifest.yml | ||
|
|
||
| # Generate unique app name | ||
| yq -i '.name = .name + "-${{ github.actor }}-" + "'$(date +"%Y%m%d%H%M")'"' manifest.yml |
There was a problem hiding this comment.
I think there are some artifacts whose name can't be repeated (maybe workflows?) in the whole CID. If it's like that, renaming the app may be not enough
There was a problem hiding this comment.
Yes, I encountered this today. It's a real pain (IMO) that workflow names have to be unique across a CID.
3 participants
No description provided.