Skip to content

Conversation

@dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Nov 5, 2024

Description

The 14-month Proxy GraphQL query always failed on iryna.oleksiuk@cru.org's account. This is due to the amount of data being returned, and the server couldn't cope.

For a very quick fix, I have called the API directly from the frontend, instead of using Next.js backend. I believe this will fix the issue for now, but the main issue is that we need to make this query into a proper GraphQL query.

I hope this doesn't cause the query to be slow for others. - In my testing, it has somewhat sped it up.

To Test:

  1. Impersonate iryna.oleksiuk@cru.org and see if the page returns a 502.
  2. Impersonate others or use your own account to ensure the report is working as it should.

Slack Message: https://cru-main.slack.com/archives/GG47BDJDU/p1730814260125489
Jira Ticket: https://jira.cru.org/browse/MPDX-8429

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz added the Preview Environment Add this label to create an Amplify Preview label Nov 5, 2024
@dr-bizz dr-bizz requested a review from canac November 5, 2024 15:26
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Preview branch generated at https://MPDX-8429.d3dytjb8adxkk5.amplifyapp.com

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Bundle sizes [mpdx-react]

Compared against 8031fd4

Route Size (gzipped) Diff
/accountLists/[accountListId]/reports/partnerCurrency/[[...contactId]] 136.98 KB +1.32 KB
/accountLists/[accountListId]/reports/salaryCurrency/[[...contactId]] 136.98 KB +1.32 KB

@canac
Copy link
Contributor

canac commented Nov 5, 2024

I tested that the request is working now when using a direct REST API call ✅

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested again, and it still works. Thanks for fixing this!

@dr-bizz dr-bizz merged commit 0b78e24 into main Nov 6, 2024
@dr-bizz dr-bizz deleted the MPDX-8429 branch November 6, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants