[no-Jira] Upgrade i18next-parser #1188
Conversation
Bundle sizes [mpdx-react]Compared against 09e40fd No significant changes found |
dr-bizz
left a comment
dr-bizz
left a comment
There was a problem hiding this comment.
When testing, I found 4 words which were lost in your PR. I confirmed that these words weren't in your translation.json and they were in the repo.
Annual
Appointment
Archive
Initiation
@dr-bizz Can you give me filenames and line numbers? I don't see |
dr-bizz
left a comment
dr-bizz
left a comment
There was a problem hiding this comment.
You are correct, main also took all 4 of those phrases out.
I was reviewing it quickly, and saw annual in a test file, so there is no instances of those words in components.
Fixes a vulnerability in vue-template-compiler.
* Replace useKeysAsDefaultValue with a defaultValue function. * Documentation: https://github.com/i18next/i18next-parser/blob/master/docs/migration.md#migrating-from-6x-to-7x * Remove nsSeparator because it was never a valid config field.
canac
force-pushed
the
dependabot-i18next-parser
branch
from
da4d33d to
6212376
Compare
|
Preview branch generated at https://dependabot-i18next-parser.d3dytjb8adxkk5.amplifyapp.com |
Description
Upgrade
i18next-parserto fix a vulnerability invue-template-compiler. Also, runyarn extractto verify that the output is the same with the old version and the new version.Testing
The
Run yarn extractcommit was made with the old version as a reference point. To verify that the the new version produces the same output, rungit restore public/locales/en/translation.json --source=mainto revert that file back to its contents onmain. Then runyarn extractand verify that there are no uncommitted changes. Without the changes to the config file, v9 produces empty strings for the values of any new labels it finds.Checklist: