MPDX-8508 Add Informational Text for Hidden Columns in Donations Table #1249
Conversation
Bundle sizes [mpdx-react]Compared against 951edd8 No significant changes found |
|
Preview branch generated at https://make-it-obvious-there-are-more-columns.d3dytjb8adxkk5.amplifyapp.com |
.gitignore
Outdated
| .lighthouseci | ||
| lighthouse-results.md | ||
|
|
||
| # Yarn Plug'n'Play (PnP) files |
There was a problem hiding this comment.
Was this change intentional? I think we want to keep the .pnp.* files committed. Otherwise, devs will have to remember to run yarn any time package.json or yarn.lock changes.
There was a problem hiding this comment.
It appears that the yarn developers intend for PnP files to be committed when using zero-install mode, which we are.
https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
There was a problem hiding this comment.
Yes, as the pnp files would always be edited after I ran yarn (without me making any changes). This causes lots of issues when checking out different branches.
I'm happy to keep them on this repo, but I need to find a way to ensure they don't change after running yarn. I'll take a look
There was a problem hiding this comment.
In the past, I've seen running yarn change the @surma/rollup-plugin-off-main-thread entry in .pnp.cjs. I thought you fixed that in d8180b5 though. What changes is yarn making to .pnp.cjs when you switch branches?
| hideDisplayName={true} | ||
| /> | ||
| <Typography variant="body2" sx={{ mt: 2, fontStyle: 'italic' }}> | ||
| On smaller screens, some columns may be hidden. Please scroll |
@dr-bizz What were the changes to |
dr-bizz
force-pushed
the
make-it-obvious-there-are-more-columns
branch
from
ce4d7d0 to
8afa291
Compare
dr-bizz
force-pushed
the
make-it-obvious-there-are-more-columns
branch
from
8afa291 to
6eac9b6
Compare
Description
If the user is on a smaller screen, when viewing the donations table in a contact's drawer, they might not see all the columns on it and not know to scroll vertically to view all the columns. We need to add text to inform the user that there might be extra columns.
HelpScout: https://secure.helpscout.net/conversation/2782399338/1269019?viewId=7296147
Jira: https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8508#
Checklist: