Skip to content

Conversation

@canac
Copy link
Contributor

@canac canac commented May 20, 2025

Description

Update the message shown to users on the Health Indicator report page who don't have HI data with wording received from Shawn and Toncho.

MPDX-8568

Testing

  • Log into an account without HI data
  • Go to the MPD Health report
  • Verify that the message matches the updated wording

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac requested a review from dr-bizz May 20, 2025 16:01
@canac canac self-assigned this May 20, 2025
@canac canac added the Preview Environment Add this label to create an Amplify Preview label May 20, 2025
@github-actions
Copy link
Contributor

Preview branch generated at https://8568-missing-data-message.d3dytjb8adxkk5.amplifyapp.com

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2025

Bundle sizes [mpdx-react]

Compared against 4b61caf

Route Size (gzipped) Diff
/accountLists 124.33 KB +4.17 KB
/accountLists/[accountListId] 274.14 KB +9.15 KB
/accountLists/[accountListId]/coaching/[coachingId] 251.8 KB +6.44 KB
/accountLists/[accountListId]/reports/coaching 251.76 KB +6.44 KB
/accountLists/[accountListId]/reports/designationAccounts 245.35 KB +5.47 KB
/accountLists/[accountListId]/reports/donations/[[...contactId]] 345.14 KB +6.37 KB
/accountLists/[accountListId]/reports/financialAccounts 253.19 KB +5.47 KB
/accountLists/[accountListId]/reports/healthIndicator 259.07 KB added
Dynamic import Size (gzipped) Diff
src/components/Contacts/ContactDetails/ContactDonationsTab/DynamicContactDonationsTab.tsx -> ./ContactDonationsTab 192.5 KB +5.47 KB

@dr-bizz
Copy link
Contributor

dr-bizz commented May 21, 2025

Looks like a typescript error is causing both issues. You might need to merge main into this PR

@canac canac force-pushed the 8568-missing-data-message branch from 2c1762a to ad109f5 Compare May 21, 2025 14:00
@canac canac merged commit 8a9dd55 into health-indicator May 21, 2025
18 checks passed
@canac canac deleted the 8568-missing-data-message branch May 21, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants