Conversation
- Move to Yarn - Upgrade all packages - Fix TS errors from upgrade - Add @next/bundle-analyzer - Name npm scripts more like existing projects
OzzieOrca
force-pushed
the
repo-updates
branch
2 times, most recently
from
d35e13b to
582b587
Compare
|
Deployment failed with the following error: |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/cru/mpdx-react/3slvtkzol |
OzzieOrca
force-pushed
the
repo-updates
branch
from
582b587 to
44c44a5
Compare
OzzieOrca
force-pushed
the
repo-updates
branch
from
ba44cc4 to
a395b3f
Compare
OzzieOrca
force-pushed
the
repo-updates
branch
from
a395b3f to
c72f7cd
Compare
| @@ -32,7 +32,7 @@ describe('TaskDrawerForm', () => { | |||
| await waitFor(() => expect(getByText('Save')).not.toBeDisabled()); | |||
| userEvent.click(getByText('Save')); | |||
| await waitFor(() => expect(onClose).toHaveBeenCalled()); | |||
| }); | |||
| }, 10000); | |||
There was a problem hiding this comment.
These tests still have issues but increasing the Jest timeout on individual tests is better than increasing it globally.
TheNoodleMoose
left a comment
TheNoodleMoose
left a comment
There was a problem hiding this comment.
Looks pretty good, excited to give yarn v2 a try!
| @@ -7,6 +7,7 @@ import { cloneDeep } from 'lodash/fp'; | |||
| import { useApp } from '../../../../App'; | |||
| import { GetNotificationsQuery } from '../../../../../../types/GetNotificationsQuery'; | |||
| import { AcknowledgeAllUserNotificationsMutation } from '../../../../../../types/AcknowledgeAllUserNotificationsMutation'; | |||
| import illustration13 from '../../../../../images/drawkit/grape/drawkit-grape-pack-illustration-13.svg'; | |||
There was a problem hiding this comment.
Do you think these should eventually be more declarative names or do you think it's fine as is?
There was a problem hiding this comment.
They are from https://www.drawkit.io/product/grape-illustration-pack and the filenames are just numbers. I could try to describe them but they are all vague and it didn't seem necessary right now. Maybe we can label them better in the future... Idk what direction design is going to want to go with them.
| @@ -32,7 +32,7 @@ describe('TaskDrawerForm', () => { | |||
| await waitFor(() => expect(getByText('Save')).not.toBeDisabled()); | |||
| userEvent.click(getByText('Save')); | |||
| await waitFor(() => expect(onClose).toHaveBeenCalled()); | |||
| }); | |||
| }, 10000); | |||
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "recommendations": [ | |||
There was a problem hiding this comment.
Will this do anything if you don't have the extensions installed?
There was a problem hiding this comment.
It shows a popup suggesting you install the extension. I might add a Jest one. Feel free to add extensions but they should probably be tooling specific instead of something like exploding rainbows as you type haha.
There was a problem hiding this comment.
But that's the best one! 🤣
3 participants
yarn installto build packages that have postinstall scripts that get placed in the.yarn/unpluggeddirectory and aren't committed to the repo since they can be machine dependant. But most other packages can just be grabbed from the repo cache.)