MPDX-7076 Preferences #853

caleballdrin · 2024-01-11T00:51:55Z

Description

Adding the Preferences page with Personal and Account accordions.
https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-7076#

Checklist:

I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
I have requested a review from another person on the project

aws-amplify-us-east-1 · 2024-01-11T01:04:18Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-853.d3dytjb8adxkk5.amplifyapp.com

canac

Great work! There's a few things that can be cleaned up. I stopped commenting for every console.log, so search the project to find the rest. My comment about generated test-ids applies to all components as well.

I have two commits in this branch: one that improves the type safety of working users and people and another that makes the collapsible email and phone number styles better. I didn't want to commit directly to your branch, but you can cherry pick them into your branch.

pages/accountLists/[accountListId]/settings/preferences.page.tsx

pages/accountLists/[accountListId]/settings/manageAccounts.page.tsx

pages/accountLists/[accountListId]/settings/preferences.page.tsx

pages/api/Schema/UserInCruOrg/dataHandler.ts

src/components/Settings/preferences/accordions/PrimaryOrgAccordion/PrimaryOrgAccordion.tsx

src/components/Settings/preferences/info/ProfileInfo.tsx

src/components/Settings/preferences/accordions/LocaleAccordion/LocaleAccordion.tsx

src/components/User/Preferences/UserPreferenceProvider.tsx

src/lib/helpScout.ts

src/components/Settings/preferences/accordions/MpdInfoAccordion/MpdInfoAccordion.tsx

src/components/Layouts/Primary/TopBar/Items/ProfileMenu/ProfileMenu.tsx

...ntacts/ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonEmail/PersonEmail.tsx

...ts/ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonEmail/PersonEmailItem.tsx

src/components/Settings/integrations/Organization/Modals/OrganizationAddAccountModal.tsx

src/components/Settings/preferences/accordions/HomeCountryAccordion/HomeCountryAccordion.tsx

src/components/Settings/preferences/accordions/MpdInfoAccordion/MpdInfoAccordion.test.tsx

src/components/Settings/preferences/accordions/MpdInfoAccordion/MpdInfoAccordion.tsx

src/components/Settings/preferences/accordions/TimeZoneAccordion/TimeZoneAccordion.tsx

src/components/Settings/preferences/GetAccountPreferences.graphql

src/lib/data/Countries.tsx

src/lib/intlFormat/intlFormat.ts

src/lib/data/Countries.tsx

dr-bizz

I have left a few comments and recommendations.

We should create an index.page.ts at /settings which redirects to /settings/preferences

src/components/Layouts/Primary/TopBar/Items/ProfileMenu/ProfileMenu.test.tsx

src/components/Settings/preferences/accordions/CurrencyAccordion/CurrencyAccordion.tsx

...preferences/accordions/HourToSendNotificationsAccordion/HourToSendNotificationsAccordion.tsx

src/components/Settings/preferences/accordions/TimeZoneAccordion/TimeZoneAccordion.tsx

...preferences/accordions/HourToSendNotificationsAccordion/HourToSendNotificationsAccordion.tsx

pages/accountLists/[accountListId]/settings/preferences.page.tsx

canac

The only issue I see is that MPDX Angular uses the lowercase locale en-us and MPDX React uses the uppercase locale en-US. It appears to be an API issue though because it is en-us in the REST constants list and en-US in the GraphQL constants list. I can ping Shelby and I'll include you, Caleb. We may want to hold off on merging until that gets resolved though.

next.config.js

dr-bizz

The code looks good
Can you merge this into staging, so Scott can preview this for QA?

src/lib/intlFormat/intlFormat.test.ts

Luxon puts a space between the time and AM in node 18.19.1 but uses a NARROW NO-BREAK SPACE (U+202F) in node 18.13.0. The inconsistency between dev and CI environments caused failing tests.

...ts/ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonEmail/PersonEmailItem.tsx

canac

Looks good! Was there anything in particular that you added that you wanted feedback on?

caleballdrin · 2024-03-06T22:39:06Z

Looks good! Was there anything in particular that you added that you wanted feedback on?

Nope, I just wanted to confirm before pushing it to prod. Scott and Robin already did QA last week. Do you think I need to ask them to do QA again? It seems like most of the changes I made they wouldn't notice a difference.

canac · 2024-03-06T22:44:43Z

@caleballdrin I'm not sure what Daniel thinks, but I think I'm good with merging. He and I have both been through it with a fine tooth comb multiple times, and Scott and Robin have looked over it too. I feel pretty confident that it works well, and if we do find an issue later on, we can always fix it then.

dr-bizz

🔥💯🔥💯 - Great job

caleballdrin added 6 commits January 10, 2024 10:43

Add Preferences

3aafc26

Add Profile Info and edit modal

6a0b493

Add parts of manage accounts and integrations

6ab66ae

Add common form and accordion components

82a9ef2

Re-use Collapsible phone and email

9e3047c

Fix skeletons and data handler

5cdde8f

caleballdrin requested review from canac and dr-bizz January 11, 2024 00:51

caleballdrin self-assigned this Jan 11, 2024

caleballdrin added the On Staging Will be merged to the staging branch by Github Actions label Jan 11, 2024

canac requested changes Jan 11, 2024

View reviewed changes

canac and others added 4 commits January 16, 2024 12:14

Improve type safety

8df0916

Make collapsible contact info components reusable

089e1b9

Fix next.js

971ef49

Merge branch 'main' into preferences

9e8e73e

caleballdrin force-pushed the preferences branch from fdedfe8 to 9e8e73e Compare January 16, 2024 20:47

Merge branch 'main' into preferences

d1b0d11

canac reviewed Jan 17, 2024

View reviewed changes

src/components/Settings/preferences/accordions/MpdInfoAccordion/MpdInfoAccordion.tsx Outdated Show resolved Hide resolved

caleballdrin added 2 commits January 17, 2024 14:23

Merge branch 'main' into preferences

2344de4

Fix PR small changes

0defdf1

canac reviewed Jan 18, 2024

View reviewed changes

src/components/Layouts/Primary/TopBar/Items/ProfileMenu/ProfileMenu.tsx Show resolved Hide resolved

caleballdrin added 8 commits January 18, 2024 09:07

Fix typescript salaryOrganizationId and remove test

bd1982d

Remove redirect link

3e9d628

Add tests

7163e03

Merge branch 'main' into preferences

faac7cd

phone number fix

b7efd65

Merge branch 'main' into preferences

bcbb113

Add UserFragment

2be9957

Add tests

fca8214

caleballdrin requested a review from dr-bizz February 29, 2024 21:35

canac reviewed Feb 29, 2024

View reviewed changes

src/lib/data/Countries.tsx Outdated Show resolved Hide resolved

Reformat accordion options and syntax changes

296c6d9

dr-bizz reviewed Mar 1, 2024

View reviewed changes

canac reviewed Mar 1, 2024

View reviewed changes

src/components/Settings/preferences/accordions/TimeZoneAccordion/TimeZoneAccordion.tsx Outdated Show resolved Hide resolved

Redirect settings and add useMemo to accordions

788afdd

canac reviewed Mar 1, 2024

View reviewed changes

...preferences/accordions/HourToSendNotificationsAccordion/HourToSendNotificationsAccordion.tsx Outdated Show resolved Hide resolved

...preferences/accordions/HourToSendNotificationsAccordion/HourToSendNotificationsAccordion.tsx Outdated Show resolved Hide resolved

canac reviewed Mar 1, 2024

View reviewed changes

pages/accountLists/[accountListId]/settings/preferences.page.tsx Outdated Show resolved Hide resolved

Fix hour accordion useMemo

2ac59ed

caleballdrin requested review from canac and dr-bizz March 4, 2024 15:22

canac approved these changes Mar 4, 2024

View reviewed changes

next.config.js Outdated Show resolved Hide resolved

dr-bizz approved these changes Mar 4, 2024

View reviewed changes

caleballdrin added 3 commits March 4, 2024 10:57

Add header border

1a3bc00

Merge branch 'main' into preferences

7d7783c

Lowercase phone/email items and adjust mpdInfoAccordion spacing

51b587e

canac reviewed Mar 6, 2024

View reviewed changes

src/lib/intlFormat/intlFormat.test.ts Show resolved Hide resolved

canac and others added 2 commits March 6, 2024 09:19

Pin the node minor version in CI

4bd2de8

Luxon puts a space between the time and AM in node 18.19.1 but uses a NARROW NO-BREAK SPACE (U+202F) in node 18.13.0. The inconsistency between dev and CI environments caused failing tests.

Remove test comment

ece3635

caleballdrin requested review from canac and dr-bizz March 6, 2024 22:06

canac reviewed Mar 6, 2024

View reviewed changes

...ts/ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonEmail/PersonEmailItem.tsx Show resolved Hide resolved

Lowercase values

4ebff5a

canac approved these changes Mar 6, 2024

View reviewed changes

dr-bizz approved these changes Mar 7, 2024

View reviewed changes

caleballdrin merged commit a248dfb into main Mar 7, 2024

caleballdrin deleted the preferences branch March 7, 2024 15:28

MPDX-7076 Preferences #853

MPDX-7076 Preferences #853

Uh oh!

Conversation

caleballdrin commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist:

Uh oh!

aws-amplify-us-east-1 bot commented Jan 11, 2024

Uh oh!

canac left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dr-bizz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

canac left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dr-bizz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

canac left a comment

Choose a reason for hiding this comment

Uh oh!

caleballdrin commented Mar 6, 2024

Uh oh!

canac commented Mar 6, 2024

Uh oh!

dr-bizz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

caleballdrin commented Jan 11, 2024 •

edited

Loading