Skip to content

fix: fixed problem with calling python in script#10

Merged
nblei merged 4 commits into
mainfrom
fix/area-cal
Nov 12, 2025
Merged

fix: fixed problem with calling python in script#10
nblei merged 4 commits into
mainfrom
fix/area-cal

Conversation

@Allenjin123
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issues with Python invocations in shell scripts where shell variables were incorrectly quoted, causing the literal variable names to be passed to Python instead of their values. The fix removes the quotes around variable references within the Python code, allowing proper shell variable expansion before the Python interpreter executes.

Key Changes:

  • Fixed Python calls in area and frequency calculations by removing quotes around shell variable references (e.g., float('$VAR')float(${VAR:-0}))
  • Added default values to prevent errors when variables are unset
  • Modified output formatting in chip area reporting

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
synth_core.sh Fixed Python variable substitution in area and frequency comparison calculations (lines 797-798, 818-819); added blank lines for formatting
scripts/synth_to_gates.sh Fixed Python variable substitution in chip area calculation (line 211); modified echo statement for total chip area output (line 238)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/synth_to_gates.sh Outdated
Comment thread synth_core.sh
Comment thread synth_core.sh
Comment thread synth_core.sh Outdated
Allenjin123 and others added 3 commits November 11, 2025 16:33
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@nblei nblei merged commit f34c4af into main Nov 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants