Hide "pages" page in filament panel#20
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughA configuration flag is added to conditionally enable or disable the Pages feature. The LayupPlugin now checks this config value before registering the PageResource to the Filament admin panel, and the documentation is updated to describe this new option. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 PHPStan (2.1.51)PHPStan was skipped because the sandbox runner could not parse its output. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
|
Hey @TheGodlyLuzer just a heads up that I see this. I have one other package that requires this to be there. I'm workin on decoupling it right now. Hoping to really review this today/tonight. |
|
Hi @chasecmiller, any updates on this? :) |
26adb0e to
19618a3
Compare
|
Hey @TheGodlyLuzer, thanks for the contribution! I rebased your branch onto current
Authorship on both commits is preserved as yours. Force-push was via |
|
Sorry, I had to get a lot of this updated. Thanks for your work! |
This PR allows users to hide the "pages" resource from their admin panels. In some cases (e.g when the user only wants to render the LayupContent from a model) the "pages" resource is not needed.
Summary by CodeRabbit
New Features
Documentation
enabledoption and its behavior.