Skip to content

Conversation

@benjaminjb
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

The delete test that looked at event timestamps to make sure the
replica deleted before the primary occasionally flaked out.

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

This PR removes that timestamp checking, quarantining that version
of the test for future debugging; and changes the in-use test to
simply verify that a cluster with replica deletes.

Both the e2e and e2e-other KUTTL tests were checked.

Other Information:
Issue [sc-15009]

The `delete` test that looked at event timestamps to make sure the
replica deleted before the primary occasionally flaked out.
This PR removes that timestamp checking, quarantining that version
of the test for future debugging; and changes the in-use test to
simply verify that a cluster with replica deletes.

Issue [sc-15009]
Copy link
Collaborator

@andrewlecuyer andrewlecuyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if we'll eventually want a specific quarantine folder 🤔 - which feels a bit different than e2e-other - but def good with moving to e2e-other for now 👍

@benjaminjb
Copy link
Contributor Author

benjaminjb commented Jul 6, 2022

I do wonder if we'll eventually want a specific quarantine folder 🤔 - which feels a bit different than e2e-other - but def good with moving to e2e-other for now 👍

On that note, I looked for a story about enabling some of these e2e-other tests, but I didn't find one. Would it be better to make one big ticket (and use that as a source to create other tickets as we decide to prioritize enabling one or other of these tests)?

Nevermind, Joseph found it, I'll leave some notes there about this particular test.

@benjaminjb benjaminjb merged commit d3300d2 into CrunchyData:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants