Skip to content

Conversation

@dsessler7
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Other Information:

var haveG string = apiG.Name
haveWantedAPIs[API{Group: haveG}] = struct{}{}

for _, apiGV := range apiG.Versions {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to loop through the Versions if we don't have the Group in wantAPIs? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expensive part was calling Kubernetes to retrieve the groups and versions. IMV, there's little benefit to discarding that information here.

@cbandy cbandy mentioned this pull request Sep 26, 2024
10 tasks
@cbandy cbandy closed this Nov 25, 2024
@cbandy cbandy deleted the api-discovery branch November 25, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants