Skip to content

Add resources from API to OTEL sidecar #4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

Add resources from API to OTEL sidecar #4104

merged 1 commit into from
Feb 26, 2025

Conversation

@benjaminjb
Copy link
Contributor

@benjaminjb benjaminjb commented Feb 25, 2025

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

No resources on OTel sidecar

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Resources on OTel sidecar

Other Information:
Issues: [PGO-2249]

dsessler7
dsessler7 approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@dsessler7 dsessler7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminjb benjaminjb merged commit bfd4160 into main Feb 26, 2025
18 of 19 checks passed
@benjaminjb benjaminjb deleted the benjb/resource-otel-sidecar branch February 26, 2025 21:03
benjaminjb added a commit that referenced this pull request Feb 28, 2025
@benjaminjb
Add resources from API to OTEL sidecar (#4104)
4008c20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsessler7 dsessler7 dsessler7 approved these changes

@cbandy cbandy Awaiting requested review from cbandy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benjaminjb @dsessler7