Skip to content

Add resources from API to OTEL sidecar #4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Add resources from API to OTEL sidecar #4104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion internal/collector/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ func (c *Config) ToYAML() (string, error) {
func NewConfig(spec *v1beta1.InstrumentationSpec) *Config {
config := &Config{
Exporters: map[ComponentID]any{
// TODO: Do we want a DebugExporter outside of development?
// https://pkg.go.dev/go.opentelemetry.io/collector/exporter/debugexporter#section-readme
DebugExporter: map[string]any{"verbosity": "detailed"},
},
Expand Down
2 changes: 1 addition & 1 deletion internal/collector/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func AddToPod(
Value: sqlQueryPassword,
},
},

Resources: spec.Resources,
SecurityContext: initialize.RestrictedSecurityContext(),
VolumeMounts: append(volumeMounts, configVolumeMount),
}
Expand Down
1 change: 0 additions & 1 deletion internal/collector/postgres_logs_transforms.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@
# https://github.com/open-telemetry/semantic-conventions/blob/v1.29.0/docs/attributes-registry/db.md
- set(attributes["db.namespace"], body["dbname"]) where IsString(body["dbname"])
- set(attributes["db.response.status_code"], body["state_code"]) where IsString(body["state_code"])
# TODO(benjb): discuss db.query.summary, db.query.text

# Postgres is multiprocess so some client/backend details align here.
#
Expand Down
Loading