Add a test helper that unmarshals JSON and YAML #4106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbandy
commented
Feb 26, 2025
| backups: { pgBackRest: { image: spec-image } }, | ||
| }`), &cluster.Spec)) | ||
| require.UnmarshalInto(t, &cluster.Spec, `{ | ||
| backups: { pgbackrest: { image: spec-image } }, |
Member
Author
There was a problem hiding this comment.
📝 The new helper identified this typo and another a few lines down.
| "loop_wait": int32(10), | ||
| "ttl": int32(30), | ||
| "retry_timeout": float64(5), | ||
| "retry_timeout": int64(5), |
Member
Author
There was a problem hiding this comment.
📝 I noticed this difference while testing validation in Kubernetes.
Comment on lines
+19
to
+26
| // Any fraction that amounts to an integral number is converted to an integer. | ||
| // See: https://go.dev/play/p/dvXRVhYO8UH | ||
| {input: `3`, expected: int64(3)}, | ||
| {input: `3.000`, expected: int64(3)}, | ||
| {input: `0.03e2`, expected: int64(3)}, | ||
| {input: `{a: 5}`, expected: map[string]any{"a": int64(5)}}, | ||
| {input: `{a: 5.000}`, expected: map[string]any{"a": int64(5)}}, | ||
| {input: `{a: 0.05e2}`, expected: map[string]any{"a": int64(5)}}, |
Member
Author
There was a problem hiding this comment.
📝 This surprised me in a recent Kubernetes and sent me to read about how the API unmarshals things.
The "sigs.k8s.io/yaml" package alone does not produce the same results as the Kubernetes API. This new function produces the same results and uses type parameters to accept input as a string or byte slice.
cbandy
force-pushed
the
unmarshal-helper
branch
from
ced296e to
be0785a
Compare
benjaminjb
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sigs.k8s.io/yamlpackage alone does not produce the same results as the Kubernetes API. This new function produces the same results and uses type parameters to accept input as a string or byte slice.Checklist:
Type of Changes: