Calculate Postgres parameters in the controller #4107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is optional, but the struct always includes it in YAML output.
benjaminjb
reviewed
Feb 28, 2025
benjaminjb
approved these changes
Feb 28, 2025
The controller assigned mandatory and default values but did nothing
with values defined in the spec.
The patroni.DynamicConfiguration function was interpreting its
schemaless fields while also combining Postgres parameters from
elsewhere. Its tests were long and complicated.
1. Postgres parameters are now extracted from the schemaless Patroni
field in their own function with its own tests. Unusual types are
handled more deliberately.
2. The PostgresCluster controller now creates a single set of Postgres
parameters based on all the fields of the PostgresCluster spec.
3. The DynamicConfiguration function is simpler (44 lines, 30% smaller)
and easier to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller assigned mandatory and default values but did nothing with values defined in the spec.
The
patroni.DynamicConfigurationfunction was interpreting its schemaless fields while also combining Postgres parameters from elsewhere. Its tests were long and complicated.Checklist:
Type of Changes: