Skip to content

Conversation

@benjaminjb
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

Our setup.sql checker only sees if the OTel metrics feature is enabled when we should check if the feature is enabled for this cluster

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Use collector.OpenTelemetryMetricsEnabled to check

Other Information:

@benjaminjb benjaminjb merged commit b5a7244 into main Mar 26, 2025
19 checks passed
@benjaminjb benjaminjb deleted the benjb/patch-exporter-enabled-check branch March 26, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants