Simplify development on macOS #4206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the build on recent versions of macOS. See: https://postgr.es/m/385134.1743523038@sss.pgh.pa.us See: https://www.github.com/pganalyze/libpg_query/issues/276
This is compatible with more environments. Co-authored-by: Ben Blattberg <ben.blattberg@crunchydata.com> Issue: PGO-1046
benjaminjb
approved these changes
Jul 14, 2025
Contributor
benjaminjb
left a comment
benjaminjb
left a comment
There was a problem hiding this comment.
What this looks like to me is
- your previous work on simplifying dev image builds (the Dockerfile, removing old build cruft) (none of which will interfere with our non-dev builds)
- pg_query for newer macs -- but does it work on our older macs still?
Member
Author
Yes, afaict. The change in Postgres and libpg_query work for older macOS, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent macOS changes require a newer pg_query.
Checklist:
Type of Changes:
Other Information:
Issue: PGO-1046