Set data directory group permissions during bootstrap #4274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Immediately after bootstrap, the data directory lacks group permissions when the storage provider ignores fsGroup. The startup container resets group permissions correctly, so pod restart works around this. Issue: PGO-300 See: c7842e7
benjaminjb
reviewed
Sep 9, 2025
Contributor
benjaminjb
left a comment
benjaminjb
left a comment
There was a problem hiding this comment.
Is this right: we would expect fsGroup to set group permissions, but in some envs, that doesn't happen correctly; and we can work around that by having initdb set the perms using this flag?
Member
Author
Yes, and it aligns with our intent in other places to actively set, enable, or activate group access. 🤔 It seems to me atm: if a tool has a setting for group permission on the filesystem, we should set it. |
benjaminjb
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Immediately after bootstrap, the data directory lacks group permissions when the storage provider ignores fsGroup. These are usually local-only providers for minkube and similar.
What is the new behavior (if this is a feature change)?
Bootstrap includes group permissions on development storage.
Other Information:
One workaround is to restart the pod. The startup container resets group permissions correctly.
Issue: PGO-300
See: c7842e7