fix example/envs.sh: use CO_NAMESPACE #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathis Raguin <mathis.raguin@epita.fr>
Contributor
|
thanks for catching that one. |
jmccormick2001
pushed a commit
that referenced
this pull request
Mar 26, 2019
* Alter config.toml, remove some unnecessary files (#556) * Update README (#573) * add regexp to check usernames passed into create user command to prevent special chars from being passed in * updating README links for documentation * fix example/envs.sh: use CO_NAMESPACE (#613) Signed-off-by: Mathis Raguin <mathis.raguin@epita.fr> * create stale.yml
jmccormick2001
pushed a commit
that referenced
this pull request
Mar 27, 2019
* Alter config.toml, remove some unnecessary files (#556) * Update README (#573) * add regexp to check usernames passed into create user command to prevent special chars from being passed in * updating README links for documentation * fix example/envs.sh: use CO_NAMESPACE (#613) Signed-off-by: Mathis Raguin <mathis.raguin@epita.fr> * create stale.yml * reffactor pg-database labels into pg-cluster labels
jmccormick2001
pushed a commit
that referenced
this pull request
Mar 27, 2019
* Alter config.toml, remove some unnecessary files (#556) * Update README (#573) * add regexp to check usernames passed into create user command to prevent special chars from being passed in * updating README links for documentation * fix example/envs.sh: use CO_NAMESPACE (#613) Signed-off-by: Mathis Raguin <mathis.raguin@epita.fr> * create stale.yml * reffactor pg-database labels into pg-cluster labels * remove helm chart
jmccormick2001
pushed a commit
that referenced
this pull request
Jun 17, 2019
* Alter config.toml, remove some unnecessary files (#556) * Update README (#573) * add regexp to check usernames passed into create user command to prevent special chars from being passed in * updating README links for documentation * fix example/envs.sh: use CO_NAMESPACE (#613) Signed-off-by: Mathis Raguin <mathis.raguin@epita.fr> * create stale.yml * Fix label used during delete of pgpool resources * Fix previous merge issue with file
jmccormick2001
pushed a commit
that referenced
this pull request
Jun 18, 2019
* Alter config.toml, remove some unnecessary files (#556) * Update README (#573) * add regexp to check usernames passed into create user command to prevent special chars from being passed in * updating README links for documentation * fix example/envs.sh: use CO_NAMESPACE (#613) Signed-off-by: Mathis Raguin <mathis.raguin@epita.fr> * create stale.yml * default pgo.yaml pgbackrest to true. command line overrides config file * Fix weird git issue with file
jmccormick2001
pushed a commit
that referenced
this pull request
Jun 20, 2019
* Alter config.toml, remove some unnecessary files (#556) * Update README (#573) * add regexp to check usernames passed into create user command to prevent special chars from being passed in * updating README links for documentation * fix example/envs.sh: use CO_NAMESPACE (#613) Signed-off-by: Mathis Raguin <mathis.raguin@epita.fr> * create stale.yml * fix differnce with upstream * Shorten backrest repo pvc name, Maintain original naming elsewhere.
jmccormick2001
pushed a commit
that referenced
this pull request
Jun 21, 2019
* Alter config.toml, remove some unnecessary files (#556) * Update README (#573) * add regexp to check usernames passed into create user command to prevent special chars from being passed in * updating README links for documentation * fix example/envs.sh: use CO_NAMESPACE (#613) Signed-off-by: Mathis Raguin <mathis.raguin@epita.fr> * create stale.yml * default pgo.yaml pgbackrest to true. command line overrides config file * Fix weird git issue with file * fix differnce with upstream * Make pgo.yaml default for pgbackrest enabled/disabled. --pgbackrest flag overrides pgo.yaml file
jmccormick2001
pushed a commit
that referenced
this pull request
Jun 24, 2019
* Alter config.toml, remove some unnecessary files (#556) * Update README (#573) * add regexp to check usernames passed into create user command to prevent special chars from being passed in * updating README links for documentation * fix example/envs.sh: use CO_NAMESPACE (#613) Signed-off-by: Mathis Raguin <mathis.raguin@epita.fr> * create stale.yml * fix differnce with upstream * exclude backrest repo from non-backup cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior? (link to any open issues here)
The example
envs.shuse neither CO_NAMESPACE nor demo.The example
envs.shuse an outdated CO_VERSION which does not support theCreateDump,RestoreDumpandScaleCluster. This will cause the installation tutorial to fail becauseCreateDumpis not a valid permission in 3.5.0.What is the new behavior (if this is a feature change)?
The example envs.sh now use CO_NAMESPACE which is by default demo.
The example envs.sh now use 3.5.1 which supports these three permissions.
Other information:
As a new user, having a broken example
envs.shis confusing. Your deployment will fail even if you follow the installation tutorial. The error is not obvious until you read the code or the changelog.