Skip to content

Finish LockedActivity for any authentication error #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crustack merged 1 commit into from
Oct 27, 2024
Merged

Finish LockedActivity for any authentication error #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/src/main/java/com/philkes/notallyx/presentation/activity/LockedActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,13 @@ abstract class LockedActivity<T : ViewBinding> : AppCompatActivity() {

override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
super.onActivityResult(requestCode, resultCode, data)
if (requestCode == REQUEST_BIOMETRIC_AUTHENTICATION && resultCode == Activity.RESULT_OK) {
notallyXApplication.isLocked = false
show()
if (requestCode == REQUEST_BIOMETRIC_AUTHENTICATION) {
if (resultCode == Activity.RESULT_OK) {
notallyXApplication.isLocked = false
show()
} else {
finish()
}
}
}

Expand Down
13 changes: 13 additions & 0 deletions app/src/main/java/com/philkes/notallyx/utils/security/LockUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,11 @@ private fun showBiometricOrPinPrompt(
super.onAuthenticationFailed()
onFailure.invoke()
}

override fun onAuthenticationError(errorCode: Int, errString: CharSequence?) {
super.onAuthenticationError(errorCode, errString)
onFailure.invoke()
}
},
)
}
Expand Down Expand Up @@ -140,6 +145,14 @@ private fun showBiometricOrPinPrompt(
super.onAuthenticationFailed()
onFailure.invoke()
}

override fun onAuthenticationError(
errorCode: Int,
errString: CharSequence?,
) {
super.onAuthenticationError(errorCode, errString)
onFailure.invoke()
}
},
null,
)
Expand Down