Skip to content

Properly set selectedExportMimeType for in-note export#774

Merged
Crustack merged 1 commit into
mainfrom
fix/772
Jan 6, 2026
Merged

Properly set selectedExportMimeType for in-note export#774
Crustack merged 1 commit into
mainfrom
fix/772

Conversation

@Crustack
Copy link
Copy Markdown
Owner

@Crustack Crustack commented Jan 6, 2026

Fixes #772

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where the selected export format was not properly retained when exporting notes, ensuring users' export preferences are consistently saved during export operations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 6, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The change adds initialization of baseModel.selectedExportMimeType in the export methods to ensure the export MIME type is stored on the model before export operations attempt to access it, preventing an uninitialized property crash.

Changes

Cohort / File(s) Change Summary
Export MIME Type Initialization
app/src/main/java/com/philkes/notallyx/utils/backup/ExportExtensions.kt
Assigns baseModel.selectedExportMimeType in LockedActivity<*>.exportNotes() and LockedActivity<*>.exportNote() to store the chosen export format prior to export execution

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A note seeks to flee in formats anew,
But first, dear model, we'll tell it to you—
Which mime type to wear on its export-bound way,
No more crashes today, hooray, hooray! ✨

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 68bee95 and 0eef670.

📒 Files selected for processing (1)
  • app/src/main/java/com/philkes/notallyx/utils/backup/ExportExtensions.kt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crustack Crustack merged commit 9e44449 into main Jan 6, 2026
1 check was pending
@Crustack Crustack deleted the fix/772 branch January 6, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

selectedExportMimeType not initialized for in Note Export

1 participant