Skip to content

Add normal dark mode next to super dark mode#817

Merged
Crustack merged 2 commits intomainfrom
feat/705
Jan 29, 2026
Merged

Add normal dark mode next to super dark mode#817
Crustack merged 2 commits intomainfrom
feat/705

Conversation

@Crustack
Copy link
Copy Markdown
Owner

@Crustack Crustack commented Jan 29, 2026

Closes #705

  • Brings back the "original" dark theme
  • Keep the "Super Dark" theme with pitch black

Summary by CodeRabbit

  • New Features

    • Introduced a new "Super Dark" theme option for enhanced dark mode customization.
  • Bug Fixes

    • Fixed widget color display to ensure colors render consistently across all note types.
  • Style

    • Refined color theming system for improved visual consistency throughout the app.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

This pull request introduces a new "SUPER_DARK" theme option to the application. It adds the SUPER_DARK theme constant to the Theme enum, applies theme logic in activities, consolidates color resource references to centralized Container color variants, defines new theme styles, and updates widget color handling to apply colors unconditionally.

Changes

Cohort / File(s) Summary
Theme Infrastructure
app/src/main/java/com/philkes/notallyx/presentation/viewmodel/preference/Preference.kt, app/src/main/java/com/philkes/notallyx/NotallyXApplication.kt, app/src/main/java/com/philkes/notallyx/presentation/activity/LockedActivity.kt
Added SUPER_DARK enum constant to Theme class; implemented theme case handling in NotallyXApplication to enable night mode for SUPER_DARK; added dynamic theme application in LockedActivity onCreate based on theme preference.
Widget Color Styling
app/src/main/java/com/philkes/notallyx/presentation/widget/WidgetFactory.kt, app/src/main/java/com/philkes/notallyx/presentation/widget/WidgetProvider.kt
Removed COLOR_DEFAULT conditional guard in WidgetFactory to always apply colors; consolidated WidgetProvider color mappings from md_theme_* variants to Container* resource references, and removed conditional check for background color application.
Theme and Color Resources
app/src/main/res/values-night/themes.xml, app/src/main/res/values-night/colors.xml, app/src/main/res/values/colors.xml
Added new AppTheme.SuperDark style; remapped theme color tokens from scrim-based to surface-based references in AppTheme; replaced hardcoded hex color values with @color/ContainerDark and @color/ContainerSuperDark references; added three new public container color resources (ContainerLight, ContainerDark, ContainerSuperDark).
Localization and Metadata
app/src/main/res/values/strings.xml, TRANSLATIONS.md
Added "super_dark" string resource (with duplicate entries flagged); updated translation coverage table from 328 to 329 total translations with adjusted per-language percentages.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 A theme so dark, it's super divine,
Where shadows dance and colors align,
From widgets to resources, the changes all flow,
Container colors now steal the show,
Darkness embraces the app's gentle glow! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Out of Scope Changes check ❓ Inconclusive The changes to WidgetFactory.kt and WidgetProvider.kt simplify color application logic and consolidate color resources, which are reasonable refactorings supporting the theme feature but extend slightly beyond the core requirement. Clarify whether the color resource consolidation and conditional removal in widget handling are necessary for the theme feature, or if they should be separated into a distinct refactoring PR.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: introducing a normal dark mode option alongside the existing super dark mode, which directly addresses issue #705's request for a selectable dark theme alternative.
Linked Issues check ✅ Passed The pull request successfully implements the requirement from issue #705 by adding a normal dark theme option (SUPER_DARK theme with appropriate colors) that allows users to switch between dark theme variants.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crustack Crustack merged commit 85cc6b9 into main Jan 29, 2026
1 check passed
@Crustack Crustack deleted the feat/705 branch January 29, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Please add an option to change the background colour of the widget.

1 participant