Skip to content

Translation/update#891

Merged
Crustack merged 4 commits intomainfrom
translation/update
Mar 5, 2026
Merged

Translation/update#891
Crustack merged 4 commits intomainfrom
translation/update

Conversation

@Crustack
Copy link
Owner

@Crustack Crustack commented Mar 5, 2026

Closes #860
Closes #872

Summary by CodeRabbit

  • Localization
    • Expanded German support with new UI labels for automatic note removal, navigation, calendar, and a "swap" action.
    • Enhanced Ukrainian translations with new deletion and navigation strings, a "super dark" label, and a corrected interval label.
    • Refined Chinese (Simplified) translations: new labels, improved plural placeholders, wording/typo fixes, and added "super dark".
  • Documentation
    • Updated translation coverage percentages for DE/UK/ZH.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d7d37dba-ad35-4d6f-847f-93506ef7613e

📥 Commits

Reviewing files that changed from the base of the PR and between 291c989 and b50be11.

📒 Files selected for processing (1)
  • TRANSLATIONS.md
✅ Files skipped from review due to trivial changes (1)
  • TRANSLATIONS.md

📝 Walkthrough

Walkthrough

Localization updates across German, Ukrainian, and Simplified Chinese resource files: new string keys added (e.g., auto_remove_deleted_notes, jump_to_top/bottom, super_dark, duplicate), multiple wording and format-specifier adjustments, and TRANSLATIONS.md coverage numbers updated.

Changes

Cohort / File(s) Summary
German translations
app/src/main/res/values-de/strings.xml
Added 8 new string resources (e.g., auto_remove_deleted_notes, auto_remove_deleted_notes_hint, jump_to_top, jump_to_bottom, swap_action, day, of_the_month, of_the_month_last). Several keys appear inserted in multiple locations (possible duplicates).
Ukrainian translations
app/src/main/res/values-uk/strings.xml
Added strings including auto_remove_deleted_notes, auto_remove_deleted_notes_hint, jump_to_top, jump_to_bottom, super_dark; modified every value ("Загальні""Кожні"). Duplicate super_dark entries present.
Simplified Chinese translations
app/src/main/res/values-zh-rCN/strings.xml
Added duplicate, duplicates (plurals), super_dark, auto_remove_deleted_notes* and hints; adjusted plural format specifiers to use %1$d, corrected format specifiers (e.g., %1$s), and reworded multiple UI strings for clarity (backup, import/export, messages).
Translation index
TRANSLATIONS.md
Updated translation coverage percentages for German, Ukrainian, and Simplified Chinese.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 I hopped through strings from near and far,
German hops and Ukrainian star,
Chinese lines I nudged with care,
Plurals fixed and hints set fair,
A tiny rabbit celebrates this multilingual lair 🌸

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes German translations (values-de/strings.xml) not mentioned in the linked issues #860 or #872, which only specify Simplified Chinese and Ukrainian updates. Clarify whether German translations are in scope or create a separate issue to track the German translation updates (#860 and #872 only cover Chinese and Ukrainian).
Title check ❓ Inconclusive The title 'Translation/update' is vague and generic, lacking specific details about which translations were updated or what changes were made. Use a more descriptive title that specifies the languages updated, such as 'Add German, Ukrainian, and Simplified Chinese translations' or 'Update translations for German, Ukrainian, and Chinese (Simplified)'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The PR implements translation updates for Simplified Chinese (#860) and Ukrainian (#872), with new German translations added. Both language-specific string resources and translation coverage percentages are updated as expected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch translation/update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/src/main/res/values-zh-rCN/strings.xml`:
- Line 327: The string resource start_view_hint contains a missing character:
change the value of the string named "start_view_hint" to include the missing
"一" so the text reads "选择应用启动时应显示的一个视图/标签。默认为笔记主视图" (i.e., insert "一" after "的"
in that string).

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d0f1b1c6-f8c8-49aa-8871-9da5a2da197a

📥 Commits

Reviewing files that changed from the base of the PR and between 071ef8f and 291c989.

⛔ Files ignored due to path filters (1)
  • app/translations.xlsx is excluded by !**/*.xlsx
📒 Files selected for processing (3)
  • app/src/main/res/values-de/strings.xml
  • app/src/main/res/values-uk/strings.xml
  • app/src/main/res/values-zh-rCN/strings.xml

<string name="start">启动视图</string>
<string name="start_view">启动视图</string>
<string name="start_view_hint">选择应用启动时应显示哪个视图/标签。默认为笔记主视图</string>
<string name="start_view_hint">选择应用启动时应显示的个视图/标签。默认为笔记主视图</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo: Missing character "一" in the translation.

The text "的个视图/标签" appears to be missing "一" (one). It should read "的一个视图/标签" to properly convey "a view/label".

Proposed fix
-    <string name="start_view_hint">选择应用启动时应显示的个视图/标签。默认为笔记主视图</string>
+    <string name="start_view_hint">选择应用启动时应显示的一个视图/标签。默认为笔记主视图</string>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<string name="start_view_hint">选择应用启动时应显示的个视图/标签。默认为笔记主视图</string>
<string name="start_view_hint">选择应用启动时应显示的一个视图/标签。默认为笔记主视图</string>
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@app/src/main/res/values-zh-rCN/strings.xml` at line 327, The string resource
start_view_hint contains a missing character: change the value of the string
named "start_view_hint" to include the missing "一" so the text reads
"选择应用启动时应显示的一个视图/标签。默认为笔记主视图" (i.e., insert "一" after "的" in that string).

@Crustack Crustack merged commit b772c4c into main Mar 5, 2026
1 check passed
@Crustack Crustack deleted the translation/update branch March 5, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ukrainian translations update Simplified Chinese translations update

1 participant