chore(rec-28): drop DBTraceProgramViewListingTest.testGetUndefinedRanges TODO-throw stub — wip sweep#39
Merged
CryptoJones merged 1 commit intoMay 26, 2026
Conversation
…ges TODO-throw stub — wip sweep Rec 28 #28-6d+ active-@ignore sweep, tenth wip-bucket deletion. The removed method's body interleaves real setup with a `TODO()` throw, which short-circuits before reaching the assertion: @test @ignore("wip: Debug/TraceModeling cluster NationalSecurityAgency#189") public void testGetUndefinedRanges() throws ... { try (Transaction tx = b.startTransaction()) { b.addData(0, b.addr(0x4000), Undefined4DataType.dataType, b.buf(1, 2, 3, 4)); b.addInstruction(0, b.addr(0x4005), b.host, b.buf(0xf4, 0)); } TODO(); // Should I expect OTHER ranges in the undefined set? assertEquals(b.set(b.range(0, 0x3fff), b.range(0x4004), b.range(0x4007, -1)), listing.getUndefinedRanges(...)); } `TODO()` throws UnsupportedOperationException, so the assertEquals below it was dead — the author's question "Should I expect OTHER ranges in the undefined set?" was never resolved into a real expected value. The hardcoded expected set is a guess. fix-or-delete: delete; issue NationalSecurityAgency#189 retains the open-question record. The static `TODO` import was the file's only consumer of `ghidra.lifecycle.Unfinished.TODO` and is dropped too. Updates docs/testing/ignore-test-inventory.md: - wip: 35 → 34 - total properly-categorized: 55 → 54 Closes NationalSecurityAgency#189 (testGetUndefinedRanges portion). Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/ Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rec 28 #28-6d+ active-
@Ignoresweep, tenth wip-bucket deletion. The removed method's body interleaves real setup with aTODO()throw, which short-circuits before reaching the assertion:TODO()throwsUnsupportedOperationException, so theassertEqualsbelow it was dead — the author's question "Should I expect OTHER ranges in the undefined set?" was never resolved into a real expected value. The hardcoded expected set is a guess. fix-or-delete: delete; issue NationalSecurityAgency#189 retains the open-question record.The static
TODOimport was the file's only consumer ofghidra.lifecycle.Unfinished.TODOand is dropped too.Updates
docs/testing/ignore-test-inventory.md:Closes NationalSecurityAgency#189 (testGetUndefinedRanges portion).
Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/