Skip to content

chore(rec-28): drop DBTraceProgramViewListingTest.testGetUndefinedRanges TODO-throw stub — wip sweep#39

Merged
CryptoJones merged 1 commit into
masterfrom
chore/rec-28-delete-DBTraceProgramViewListingTest-testGetUndefinedRanges
May 26, 2026
Merged

chore(rec-28): drop DBTraceProgramViewListingTest.testGetUndefinedRanges TODO-throw stub — wip sweep#39
CryptoJones merged 1 commit into
masterfrom
chore/rec-28-delete-DBTraceProgramViewListingTest-testGetUndefinedRanges

Conversation

@CryptoJones
Copy link
Copy Markdown
Owner

Rec 28 #28-6d+ active-@Ignore sweep, tenth wip-bucket deletion. The removed method's body interleaves real setup with a TODO() throw, which short-circuits before reaching the assertion:

@Test
@Ignore("wip: Debug/TraceModeling cluster #189")
public void testGetUndefinedRanges() throws ... {
    try (Transaction tx = b.startTransaction()) {
        b.addData(0, b.addr(0x4000), Undefined4DataType.dataType, b.buf(1, 2, 3, 4));
        b.addInstruction(0, b.addr(0x4005), b.host, b.buf(0xf4, 0));
    }

    TODO(); // Should I expect OTHER ranges in the undefined set?
    assertEquals(b.set(b.range(0, 0x3fff), b.range(0x4004), b.range(0x4007, -1)),
        listing.getUndefinedRanges(...));
}

TODO() throws UnsupportedOperationException, so the assertEquals below it was dead — the author's question "Should I expect OTHER ranges in the undefined set?" was never resolved into a real expected value. The hardcoded expected set is a guess. fix-or-delete: delete; issue NationalSecurityAgency#189 retains the open-question record.

The static TODO import was the file's only consumer of ghidra.lifecycle.Unfinished.TODO and is dropped too.

Updates docs/testing/ignore-test-inventory.md:

  • wip: 35 → 34
  • total properly-categorized: 55 → 54

Closes NationalSecurityAgency#189 (testGetUndefinedRanges portion).

Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/

…ges TODO-throw stub — wip sweep

Rec 28 #28-6d+ active-@ignore sweep, tenth wip-bucket deletion. The
removed method's body interleaves real setup with a `TODO()` throw,
which short-circuits before reaching the assertion:

    @test
    @ignore("wip: Debug/TraceModeling cluster NationalSecurityAgency#189")
    public void testGetUndefinedRanges() throws ... {
        try (Transaction tx = b.startTransaction()) {
            b.addData(0, b.addr(0x4000), Undefined4DataType.dataType, b.buf(1, 2, 3, 4));
            b.addInstruction(0, b.addr(0x4005), b.host, b.buf(0xf4, 0));
        }

        TODO(); // Should I expect OTHER ranges in the undefined set?
        assertEquals(b.set(b.range(0, 0x3fff), b.range(0x4004), b.range(0x4007, -1)),
            listing.getUndefinedRanges(...));
    }

`TODO()` throws UnsupportedOperationException, so the assertEquals
below it was dead — the author's question "Should I expect OTHER
ranges in the undefined set?" was never resolved into a real expected
value. The hardcoded expected set is a guess. fix-or-delete: delete;
issue NationalSecurityAgency#189 retains the open-question record.

The static `TODO` import was the file's only consumer of
`ghidra.lifecycle.Unfinished.TODO` and is dropped too.

Updates docs/testing/ignore-test-inventory.md:
- wip: 35 → 34
- total properly-categorized: 55 → 54

Closes NationalSecurityAgency#189 (testGetUndefinedRanges portion).

Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@CryptoJones CryptoJones merged commit fad49ad into master May 26, 2026
9 of 11 checks passed
@CryptoJones CryptoJones deleted the chore/rec-28-delete-DBTraceProgramViewListingTest-testGetUndefinedRanges branch May 26, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support force loading of PDB files

1 participant