chore(compose): set NODE_ENV=production by default on the api service#198
Merged
Merged
Conversation
The migrate service in docker-compose.yml sets `NODE_ENV: production`
(line 78), but the api service was missing the same default. Result:
in compose deployments the api process runs without NODE_ENV set,
so libraries that gate performance optimizations on
`process.env.NODE_ENV === 'production'` silently fall back to dev
mode — Express view cache off, Sequelize debug paths active, pg
pool sized differently, etc.
This isn't a functional bug — every code path works — but it's an
operational quality issue: compose deployments aren't actually
running in production mode by libraries' standards, despite the
operator's intent.
Add `NODE_ENV: ${NODE_ENV:-production}` so:
- Default compose deployments run in production mode automatically
- Operators who want dev compose (e.g. live-reload testing) can
override via `NODE_ENV=development` in .env
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #197.
Summary
The migrate service set
NODE_ENV: productionbut the api service didn't. Libraries that gate optimizations onNODE_ENV === 'production'(Express, Sequelize, pg, …) were running in dev mode inside what an operator would assume is a production deployment.Add
NODE_ENV: ${NODE_ENV:-production}to the api service. Operators who want dev compose can override viaNODE_ENV=developmentin.env.Test plan
npm run lintcleannpm test— 646 passed (compose-only change, no test surface)Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/