Skip to content

fix(security): defuse CSV-formula injection in /v1/customer/export.csv #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CryptoJones merged 1 commit into from
May 19, 2026
Merged

fix(security): defuse CSV-formula injection in /v1/customer/export.csv #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions app/controllers/customercontroller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const log = require('../config/logger.js');
const auth = require('../middleware/auth.js');
const { buildLinkHeader } = require('../middleware/pagination.js');
const { makeBulkCreate } = require('./_bulk-helpers.js');
const { escapeCsvCell } = require('./_csv-escape.js');
const Customer = db.Customer;

// IsMaster / GetCompanyId previously lived inline in this file and
Expand Down Expand Up @@ -359,18 +360,21 @@ exports.exportCsv = async (req, res) => {
const truncated = rows.length > limit;
if (truncated) rows = rows.slice(0, limit);

// CSV serialization. Wraps every field in quotes (simpler than
// detecting which ones need it) and doubles any embedded quotes.
// CSV serialization via the shared helper. Includes RFC 4180
// quote-wrapping AND the OWASP formula-injection guard — any cell
// starting with =, +, -, @, tab, or CR is prefixed with a single
// quote so the spreadsheet engine treats it as text. Customer
// free-text fields (custCompanyName, custFName, etc.) are
// user-supplied per-tenant, so an entry like `=HYPERLINK(...)`
// would otherwise fire when a co-tenant operator opens the
// export. See _csv-escape.js + the timeentry counterpart (#266).
const FIELDS = [
'custId', 'custCompanyName', 'custFName', 'custLName',
'custAddress1', 'custAddress2',
'custCity', 'custState', 'custZip',
'custPhone', 'custEmail', 'custCompId',
];
const escape = (val) => {
if (val === null || val === undefined) return '""';
return '"' + String(val).replace(/"/g, '""') + '"';
};
const escape = escapeCsvCell;
const lines = [];
lines.push(FIELDS.join(','));
for (const r of rows) {
Expand Down