chore(versioninfo): natural-case the create-success message#295
Merged
Conversation
The create handler returned \`message: "VersionInfo created."\` — the CamelCase model name. Every other entity's create handler uses natural English: "Customer created.", "Time entry created.", "PO vendor created.", etc. VersionInfo was the only outlier. Switch to "Version info created." to match the rest of the API surface. Verified via grep that no tests assert on the literal old string, so the change is safe. No behavior change beyond the message text. 761 tests still pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
versioninfocontroller.createreturnedmessage: "VersionInfo created."— the CamelCase model name. Every other entity's create handler uses natural English ("Customer created.","Time entry created.","PO vendor created.", etc.). VersionInfo was the only outlier.Switch to
"Version info created."to match the rest of the API surface.Test plan
grep -rn "VersionInfo created"intests/returned no hits — no test asserts on the literal old string.npm run lint && npm test— 761 passing.Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/