ci(github): scope workflow GITHUB_TOKEN to contents:read (#330)#331
Merged
Conversation
The `tests` workflow had no explicit `permissions:` block, which means the auto-provisioned GITHUB_TOKEN inherits the repository default — typically read+write on contents, issues, pull-requests, and a handful of other surfaces. A compromised dependency, a malicious upstream action, or a workflow-injection foothold via PR-author-controlled input could then push to master, open issues, or close/comment PRs using the workflow token. The test workflow only needs to clone the repo and report status via the default check API — no write surface required. Pin the job-level scope to `contents: read` so any future compromise can do strictly less damage. Matches the GitHub Actions hardening guide's "least-privilege GITHUB_TOKEN" recommendation. Codeberg's Woodpecker runner has a different token model (no auto-provisioned write-capable token; it uses a per-pipeline secret instead), so the .woodpecker.yml side needs no parallel change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #330.
Summary
Adds an explicit
permissions: contents: readblock to.github/workflows/test.ymlso the auto-provisioned GITHUB_TOKEN can't be coerced into pushing to master / opening issues / manipulating PRs if a dependency or action in the workflow is compromised.The test workflow only needs to clone the repo and report status — no write surface required.
Test plan
npm run lint && npm test— 783 passing (CI config change, no app-side impact).Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/