docs(openapi): declare POST /v1/customer/bulk 201 envelope shape (#332)#333
Merged
Merged
Conversation
Same drift pattern as #316 (customer POST) and #326 (timeentry POST), now for the bulk variant. The spec declared description + the Idempotency-Replay header but no content schema, so SDK code-gen modeled the response body as untyped. The controller (`_bulk-helpers.makeBulkCreate`) emits: { message, count, customers: Customer[] } Pin that shape in the spec and add a corresponding test in `tests/api/openapi.test.js`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #332.
Summary
Same envelope-drift fix as #316 (customer POST) and #326 (timeentry POST), now for customer/bulk. The 201 response declares description + header but no content schema; pin the
{message, count, customers}envelope and add a test.Test plan
npm run lint && npm test— 784 passing (was 783).Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/