refactor(customer): consolidate bulkCreate onto shared factory#92
Merged
Merged
Conversation
The Customer controller's bulkCreate predates the `makeBulkCreate` factory in `app/controllers/_bulk-helpers.js` (introduced in P3-H for the other 5 direct-compId entities). The two implementations had identical semantics, just duplicated code. This swaps Customer's hand-rolled handler for a call to the factory, dropping ~85 lines. The factory accepts: - Model: Customer - modelKey: 'Customer' (for log lines) - compIdField: 'custCompId' - allowedFields: the same 11-column whitelist - archField: 'custArch' - bodyKey / createdKey: 'customers' (request and response shape preserved exactly) Behavior on the wire is unchanged. The same 11 test cases in tests/api/customer-bulk.test.js continue to pass. Tests: 472 pass / 4 skip. Lint clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #81 (P3-H). Customer's hand-rolled
bulkCreatepredated themakeBulkCreatefactory; identical semantics, ~85 lines of duplication.Summary
app/controllers/_bulk-helpers.js.tests/api/customer-bulk.test.jscontinues to pass.Test plan
This code proudly made in Nebraska. GO BIG RED! 🌽 https://xkcd.com/2347/