chore: trim dead code and run mypy in CI#16
Merged
Conversation
Three small cleanups plus a CI gap: - Wire `mypy src` into both pipelines (GitHub Actions + Woodpecker). The project declares `strict = true` in pyproject.toml but nothing ever ran mypy — it passes clean today, so this just keeps it that way. - Drop the `.prose-omi li.task` CSS rule. The bundled marked renderer emits task list items as plain `<li>` (the checkbox is a nested `<input>`), so the selector never matched. - Fix a stale comment in seeds.py that pointed at `store.SECTIONS`, a symbol that doesn't exist; the real parse contract is store.parse_note. - Make `check_prereqs()` return None — it only raises or logs, and no caller used the missing-tools list it returned. No behavior change; all 63 tests, ruff, and mypy pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15.
Summary
mypy srcinto both pipelines (GitHub Actions + Woodpecker).pyproject.tomlalready hasstrict = true; mypy passes clean today, so this just keeps it green..prose-omi li.taskCSS rule — the bundledmarkedemits task list items as plain<li>, so it never matched.store.SECTIONSreference in theseeds.pytemplate comment (no such symbol; real contract isstore.parse_note).check_prereqs()is now-> None— it only raises or logs, and no caller used the returned list.Test plan
ruff check .— cleanmypy src— Success: no issues found in 8 source filespytest -q— 63 passedProudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/