Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the ZO (zero/one) sampling path in EncryptorT::sampleZO, which is used during encryption/key generation to populate the vx_buffer_ polynomial(s) prior to NTT.
Changes:
- Adjusts where RNG output is stored/read from in
sampleZOto avoid clobbering sampled bits while extracting them. - Modifies the sampling loop bounds and adds special handling for the final coefficient.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leejonghyeong
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue #5