fix(dev/preflight): resolve REPO three levels up from script location#123
Merged
couragehong merged 1 commit intoMay 8, 2026
Merged
Conversation
The path-fix from PR #120 review never made it into the merged commit (staging order issue) — REPO landed pointing at scripts/dev/v04/ itself, so step 1's `cd "$REPO"` followed by `go build ./cmd/rune-mcp` tries to stat scripts/dev/v04/cmd/rune-mcp, which doesn't exist, and the script aborts with a build failure. Going up three directories from scripts/dev/v04/ resolves to the repo root regardless of where the user invokes the script from, restoring the intended idempotent pre-flight behavior. Verified locally: every section (build / plugin source / vault / runed / ~/.rune scrub / mcpServers / plugin cache) reports green and the script exits 0. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path-fix from PR #120 review never made it into the merged commit (staging order issue) — REPO landed pointing at scripts/dev/v04/ itself, so step 1's
cd "$REPO"followed bygo build ./cmd/rune-mcptries to stat scripts/dev/v04/cmd/rune-mcp, which doesn't exist, and the script aborts with a build failure.Going up three directories from scripts/dev/v04/ resolves to the repo root regardless of where the user invokes the script from, restoring the intended idempotent pre-flight behavior.
Verified locally: every section (build / plugin source / vault / runed / ~/.rune scrub / mcpServers / plugin cache) reports green and the script exits 0.