fix(status): remove false-negative MCP server logs check#83
Open
couragehong wants to merge 1 commit intomainfrom
Open
fix(status): remove false-negative MCP server logs check#83couragehong wants to merge 1 commit intomainfrom
couragehong wants to merge 1 commit intomainfrom
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed: Removed the
Infrastructureblock (4 lines including trailing blank) fromcommands/claude/status.md. The block contained two checks —MCP server logsandPython venv— that rendered immediately after theSystem Healthsection.Why: The
MCP server logscheck referenced~/.rune/logs, a directory that is only ever created byscripts/start-mcp-servers.sh(standalone daemon mode). In plugin mode — where the MCP server runs as a stdio child spawned bybootstrap-mcp.sh— the directory is never created. The Python server useslogging.getLogger("rune.mcp")with noFileHandler(stderr only), andbootstrap-mcp.shdoes not create the path either. Verified withrg 'FileHandler|rune/logs' mcp/→ 0 matches. The result was[✗] MCP server logs: ~/.rune/logs missingon every/rune:statusinvocation in an otherwise-healthy report, causing users to think the server was broken.The
Python venv: foundline is removed in the same block because it is implied by theSystem Healthsection above — diagnostics can only respond if the venv is already alive, so a separate venv check carried no new information. The useful part of that line (the actual checkout path) will be re-surfaced in a more meaningful form via the follow-up issue linked below.commands/rune/status.tomlalready avoids this anti-pattern and uses aMCP Tools: capture/recall/diagnostics availabilityblock instead, which is the reference design this PR implicitly moves the MD template toward.Validation
/rune:statustemplate rendering. Verified manually by running/rune:statusin Claude Code after applying the change and confirming the false-negative line is gone; remaining output unchanged.README.md,CONTRIBUTING.md,docs/*, and other command templates do not reference the removed lines. Verified withrg 'MCP server logs|~/\.rune/logs|stale/missing' commands/→ only match is the removed line itself.Cross-Agent Invariants
scripts/bootstrap-mcp.shremains the single source of truth for runtime prep (venv/deps/self-heal) — no script changescodex mcp ...) are clearly separated from cross-agent/common instructions — no command-body changesSKILL.md,commands/rune/*.toml, andAGENT_INTEGRATION.mdstay consistent on boundaries — this PR actually improves consistency:commands/rune/status.tomlalready uses aMCP Toolsavailability block instead of the brokenInfrastructureblock, and this PR brings the Claude MD template closer to that reference design (reduces MD↔TOML drift rather than introducing it)Notes for Reviewers
Risk areas: Very low.
The removed section was always producing a false-negative in plugin mode, so removing it only removes noise; no user workflow depended on it being present.
Python venv: foundwas purely cosmetic (implied by System Health).No code or schema changes — purely template text.
Backward compatibility impact: None.
The template is consumed by the LLM running
/rune:status; removing a section just means that section disappears from future status reports.No data schema, MCP tool response shape, or CLI interface changes.
Older Rune installs running this updated command will simply see a slightly shorter, more accurate status report.