Conversation
# Conflicts: # conseil-api/src/main/scala/tech/cryptonomic/conseil/api/routes/platform/discovery/GenericPlatformDiscoveryOperations.scala
… into feature/jakarta-protocol-update
|
Kudos, SonarCloud Quality Gate passed!
|
vishakh
approved these changes
Jun 8, 2022
Comment on lines
+93
to
+105
| yay_count bigint, | ||
| nay_count bigint, | ||
| pass_count bigint, | ||
| yay_rolls bigint, | ||
| nay_rolls bigint, | ||
| pass_rolls bigint, | ||
| total_rolls bigint, | ||
| block_yay_count bigint, | ||
| block_nay_count bigint, | ||
| block_pass_count bigint, | ||
| block_yay_rolls bigint, | ||
| block_nay_rolls bigint, | ||
| block_pass_rolls bigint, |
Contributor
There was a problem hiding this comment.
Why did you have to change these types?
Contributor
Author
There was a problem hiding this comment.
because rolls were int32 on the node and currently they were moved to be int64, so to be safe everything rolls related is int64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR with changes for Jakarta protocol update. Currently pushed to dockerhub with tag
jakartanet-02for testing.